Skip to content

Conversation

michelp
Copy link
Member

@michelp michelp commented Aug 12, 2021

This fixes a Bad Address problem Tim found saving large matrices.

@eriknw
Copy link
Member

eriknw commented Aug 12, 2021

Nice. So it was iso. Good guess.

It's weird that this PR is showing the other files for building wheels and SuiteSparse:GraphBLAS. Perhaps the branch for this PR is based on one that had all the commits from your previous PR, which got squashed when merged into main. Meh. Probably fine.

The changes look good to me. If you think it's ready, then don't forget to squash into a single commit.

@michelp
Copy link
Member Author

michelp commented Aug 12, 2021

Nice. So it was iso. Good guess.

It's weird that this PR is showing the other files for building wheels and SuiteSparse:GraphBLAS. Perhaps the branch for this PR is based on one that had all the commits from your previous PR, which got squashed when merged into main. Meh. Probably fine.

The changes look good to me. If you think it's ready, then don't forget to squash into a single commit.

Yeah I dunno what's up with that but it looks harmless. Squashing...

@michelp michelp merged commit 3db168a into GraphBLAS:main Aug 12, 2021
@michelp michelp deleted the bad-address-on-large-iso branch August 12, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants