Skip to content

Prettify? #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2017
Merged

Prettify? #2

merged 2 commits into from
Dec 13, 2017

Conversation

lorensr
Copy link
Member

@lorensr lorensr commented Dec 12, 2017

Ran through prettier with the settings I've been using on ch 5 code:

  "prettier.singleQuote": true,
  "prettier.semi": false,

The single quotes are ubiquitous, and the lack of semis, besides being a strong personal preference, I'm seeing more often, eg Zeit

@jeresig
Copy link
Contributor

jeresig commented Dec 12, 2017

@lorensr Could you include a .pretterrc file with this, as well? Would be useful to future folks who are updating the code. Thanks!

@lorensr
Copy link
Member Author

lorensr commented Dec 12, 2017

👍 good point, done!

@jeresig
Copy link
Contributor

jeresig commented Dec 13, 2017

Thank you, @lorensr!

@jeresig jeresig merged commit 3b66b65 into master Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jeresig jeresig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorensr @jeresig