Use Android Architecture Components #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-stoneuk
commented
Jul 13, 2020
| chapterId = chapter.id, | ||
| chapterNumber = chapter.number?.toInt() ?: -1, | ||
| chapterTitle = chapter.title | ||
| chapterTitle = if (chapter.number == null) chapter.title else getString( |
There was a problem hiding this comment.
Instead of passing in the chapter title, we generate it here before passing it to the second fragment. This means we can use this argument in the nav editor.
daniel-stoneuk
commented
Jul 13, 2020
| tools:layout="@layout/sections_fragment"> | ||
| tools:layout="@layout/sections_fragment" | ||
| android:label="{chapterTitle}"> | ||
|
|
There was a problem hiding this comment.
Here we set the label of the fragment to the chapterTitle argument that we pass in when navigating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains how I would use the Apollo Android Library with Android Architecture components.