Use similar method to apollo-android sample app for apolloClient #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got it. Could you do another PR with the simpler singleton code you'd use? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store a single instance of apolloClient in the application class and retrieve by casting the Application to our GuideApp class. This adds extra complexity and is not how I would personally maintain a singleton object, therefore, I don't think this should be used as a guide since there are other ways to do this.
See: https://github.com/apollographql/apollo-android/blob/master/samples/kotlin-sample/src/main/java/com/apollographql/apollo/kotlinsample/repositories/MainActivity.kt