Skip to content

Prevent Token linked list from leaking. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2017

Conversation

williambailey
Copy link
Contributor

Token ownership is now only from the parent Token to its next Token. This allows ARC to be able to free tokens once they are no longer used. Without this schema.execute(...) will continue to eat memory without giving it back as queries are served.

Hopefully no unwanted side effects to this small update.

@codecov-io
Copy link

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   79.72%   79.72%           
=======================================
  Files          71       71           
  Lines        8547     8547           
=======================================
  Hits         6814     6814           
  Misses       1733     1733
Impacted Files Coverage Δ
Sources/GraphQL/Language/AST.swift 70.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c606130...bd79415. Read the comment docs.

@paulofaria paulofaria merged commit ba21e56 into GraphQLSwift:master May 16, 2017
@paulofaria
Copy link
Member

nice catch! thanks 😉

@williambailey williambailey deleted the token_leak branch June 19, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants