-
-
Notifications
You must be signed in to change notification settings - Fork 882
Add embedable images #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add embedable images #564
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
added85
Add embedable bitmaps
0HyperCube a1c00ee
Merge branch 'master' into bitmap-images
0HyperCube 8f3cb14
Initial work on blob urls
0HyperCube bb8fc4d
Finish implementing data url
0HyperCube fa3fc22
Fix some bugs
0HyperCube 0bdf991
Rename bitmap to image
0HyperCube ea33bea
Fix loading image on document load
0HyperCube 70ffa28
Add transform properties for image
0HyperCube 510687c
Remove some logging
0HyperCube bb53b05
Add image dimensions
0HyperCube 91068d2
Implement system copy and paste
0HyperCube 230a128
Fix pasting images
0HyperCube f4436c4
Merge branch 'master' into bitmap-images
Keavon 6debcc7
Fix test
0HyperCube 57d5145
Merge branch 'master' into bitmap-images
0HyperCube 790154d
Address code review
0HyperCube b480138
Merge branch 'master' into bitmap-images
0HyperCube File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same line as the line below, so the identical code runs in either case, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No - it returns from the function in this case.The check needs to be before pushing the message to prevent a clone.