"Go Live" items #18

mrcasual · 2024-05-21T23:37:26Z

This implements #16 and more.

Install the build file or clone the repo and run npm i && composer i && grunt.

To do

Improve styles, especially for DataTables
Add tooltip/docs links for each setting

'tooltip'           => __( 'When enabled it will only show any View entries after a search is performed.', 'gk-gravityview' ),
					'article'           => array(
						'id'  => '5c772fa02c7d3a0cb9320a84',
						'url' => 'https://docs.gravitykit.com/article/536-how-to-hide-results-and-only-display-them-if-a-search-is-performed',
					),

To test

Foundation

All options under GravityKit > Settings > Gravityview > Dashboard Views

View Editor

All options under the Dashboard Views tab
Field setting to exclude it from the frontend or Dashboard display

Various

Directory/Single Entry/Edit Entry views, pagination, sorting, etc.
Lightbox (file upload file gallery with images)
DataTables (with and without Ajax)
GravityEdit, GravityCalendar, GravityCharts, entry notes, entry revisions, etc.

P.S. When the Dashboard View is open, you can go to the View Editor by pressing Alt/⌥+⇧+V+E.

💾 Build file (0870858).

…orks

Removing (at the moment) unnecessary hooks/methods and moving things around.

At the moment the script configures "VE" shortcut to open the View editor :)

By defalt, the slug will be a URL-safe name of the Admin menu as configured under GravityView's global settings; this slug can also be changed using a filter. This also adds helper methods to get the submenu slug, as well as to check if the submenu is a Dashboard View.

Currently there's a single setting, but more will be added as per #9

It's now Alt/Option + V + E to open the View editor. The code was refactored to allow for easy addition of other shortcuts.

This also refactors how assets are loaded and their names.

This is work in progress as the CI has not been configured and there are no releases yet.

We enqueue frontend assets in the View::render_view() method.

zackkatz · 2024-05-27T16:45:09Z

~~@mrcasual I'll add issues I find here in the comments.~~

~~On saving a pre-existing View that hasn't been saved since enabling Dashboard Views:~~

  thrown in /Users/zackkatz/Local/dev/app/public/wp-content/plugins/gravityview-dashboard/src/AdminMenu.php on line 128
[27-May-2024 16:44:50 UTC] PHP Fatal error:  Uncaught Error: Call to undefined method GravityKit\GravityView\DashboardViews\AdminMenu::get_menu_position_by_id() in /Users/zackkatz/Local/dev/app/public/wp-content/plugins/gravityview-dashboard/src/AdminMenu.php:128
Stack trace:
#0 /Users/zackkatz/Local/dev/app/public/wp-includes/class-wp-hook.php(324): GravityKit\GravityView\DashboardViews\AdminMenu->add_admin_menu('')
#1 /Users/zackkatz/Local/dev/app/public/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters(NULL, Array)
#2 /Users/zackkatz/Local/dev/app/public/wp-includes/plugin.php(517): WP_Hook->do_action(Array)
#3 /Users/zackkatz/Local/dev/app/public/wp-admin/includes/menu.php(161): do_action('admin_menu', '')
#4 /Users/zackkatz/Local/dev/app/public/wp-admin/menu.php(422): require_once('/Users/zackkatz...')
#5 /Users/zackkatz/Local/dev/app/public/wp-admin/admin.php(158): require('/Users/zackkatz...')
#6 /Users/zackkatz/Local/dev/app/public/wp-admin/post.php(12): require_once('/Users/zackkatz...')
#7 /Users/zackkatz/.composer/vendor/laravel/valet/server.php(250): require('/Users/zackkatz...')
#8 {main}
  thrown in /Users/zackkatz/Local/dev/app/public/wp-content/plugins/gravityview-dashboard/src/AdminMenu.php on line 128

Resolved: https://gravitykit.slack.com/archives/C727B06MB/p1716830269227759

zackkatz · 2024-05-27T17:34:49Z

~~@mrcasual I'm having issues with restricting access. This happens even when selecting all roles.~~

https://www.loom.com/share/b6be0528c69548d5960adfbf743fd3e2

Resolved: https://gravitykit.slack.com/archives/C727B06MB/p1716837388289959

This needs more language tweaking, but I think an action to prevent viewing is stronger than a default that enables it.

Finishes work started on f7641e7

https://i.gravitykit.com/i/vPaHhu

crbdev · 2024-05-30T03:15:44Z

Getting a critical error when trying to edit entries in a dashboard View

Request::is_edit_entry() is expected to return an entry if it is indeed an edit entry screen.

mrcasual · 2024-05-30T12:20:04Z

@crbdev,

Getting a critical error when trying to edit entries in a dashboard View

Fixed in 0870858. It would help to know the actual error message in the future. You can enable debugging on your site or install this plugin.

rafaehlers · 2024-06-03T23:14:01Z

Should we clarify this text to mention that the View "name" here is the actual menu link?
Let's clarify the text here mentioning that "Group order" means "order of the View within the group":
A-Z Filters work ✅
The Approve Entries (ajax) field is not yet supported

mrcasual · 2024-06-04T02:08:12Z

@rafaehlers,

The Approve Entries (ajax) field is not yet supported

Entry approval works fine for me.

zackkatz · 2024-06-04T02:17:13Z

Approve Entries works for me as well using all layouts (Table, List, DataTables, DIY) @rafaehlers . What layout were you using?

crbdev · 2024-06-05T10:16:30Z

When adding a "Gravity Forms" widget to a View, the form does not render in the dashboard.

Entry approval worked for me, too.

mrcasual added 30 commits May 1, 2024 16:16

Remove EDD and legacy text domain loading

6546b8a

Update Grunt config & remove legacy translations

6501f7f

Remove Travis configuration

69cbb80

Update code to use PSR-4 loading

4de1db5

Remove legacy GV extension class & optimize plugin loading

5f5959a

Clean up .gitignore

7428697

Exclude files from the build archive

10e0ab3

Use short array syntax

635d2f4

Add Pico CSS

12932cb

Fix filter name

c40298f

Define global constant with plugin file

0c82696

Add Chota, Cirrus, Marx, MVP, Picnic, Pure, Sakura, Simple CSS framew…

031469c

…orks

Add stylesheet selection as a global GravityView setting

aaa6df9

Add Pico CSS to GravityView global settings

ab157e3

Generate CSS framework dropdown choices from an object

36560ab

Add missing class import

285e7a0

Start refactoring the main Plugin class and Settings/Menu

11157e3

Removing (at the moment) unnecessary hooks/methods and moving things around.

Set 'dashboard_view' on $_REQUEST when navigating to the View menu item

d3af75b

Update hook names for managing admin menu items

2db0c1a

Add JS script to be enqueued on when displaying the Dashboard View

c4c6978

At the moment the script configures "VE" shortcut to open the View editor :)

Fix undefined index

783a8c1

Add Dashboards View settings to the View editor

32891ca

Currently there's a single setting, but more will be added as per #9

Return only those Views that were configured for Dashboard display

631823d

Update @SInCE tags

9b9f942

Refactor the main JS and add modifier key to shortcuts

9516545

It's now Alt/Option + V + E to open the View editor. The code was refactored to allow for easy addition of other shortcuts.

Add user role selection to View editor's Dashboard Views settings

f326b94

This also refactors how assets are loaded and their names.

Update repo's readme.md

293a6c9

This is work in progress as the CI has not been configured and there are no releases yet.

Update styles for the role selection element

26df3d0

Fix improper ID used for the label element

a5ecd3d

zackkatz and others added 3 commits May 27, 2024 12:26

Add Dashicon [ci skip]

b1eab6c

Remove redundant code

9de9f68

We enqueue frontend assets in the View::render_view() method.

Remove unused variable [ci skip]

22f2a94

zackkatz and others added 13 commits May 27, 2024 15:35

Exclude build and cache files

3b6af1f

Fix DataTables length input display

3f1879d

Invert the setting to be internal-only

f7641e7

This needs more language tweaking, but I think an action to prevent viewing is stronger than a default that enables it.

Complete "internal-only" setting name modification

b8e78b1

Finishes work started on f7641e7

Disable "View on website." link if internal-only

e394095

Add method to implement DRY

f4df97f

Prevent Permalink: showing up when internal-only

b50fc36

Remove Views from being available via query

61c893c

Restore seeing Views in Views table

b80b42d

Use shorthand array syntax & format code

3868b1f

Fix z-index conflict with Yoast

b50cf49

https://i.gravitykit.com/i/vPaHhu

Move user role settings up

13c3d87

Tweak some wording

83b222e

GravityKit deleted a comment from zackkatz May 27, 2024

zackkatz added 2 commits May 27, 2024 17:55

Add filter for menu icon

9a5e3a2

Add better description [ci skip]

a287711

Fix edit entry not working

0870858

Request::is_edit_entry() is expected to return an entry if it is indeed an edit entry screen.

Update filter name to use the our naming convention [ci skip]

88ef158

Update language per @rafaehlers feedback

1a21d13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"Go Live" items #18

"Go Live" items #18

mrcasual commented May 21, 2024 •

edited

zackkatz commented May 27, 2024 •

edited by mrcasual

zackkatz commented May 27, 2024 •

edited by mrcasual

crbdev commented May 30, 2024

mrcasual commented May 30, 2024

rafaehlers commented Jun 3, 2024 •

edited by zackkatz

mrcasual commented Jun 4, 2024 •

edited

zackkatz commented Jun 4, 2024 •

edited

crbdev commented Jun 5, 2024 •

edited

"Go Live" items #18

Are you sure you want to change the base?

"Go Live" items #18

Conversation

mrcasual commented May 21, 2024 • edited

To do

To test

Foundation

View Editor

Various

zackkatz commented May 27, 2024 • edited by mrcasual

zackkatz commented May 27, 2024 • edited by mrcasual

crbdev commented May 30, 2024

mrcasual commented May 30, 2024

rafaehlers commented Jun 3, 2024 • edited by zackkatz

mrcasual commented Jun 4, 2024 • edited

zackkatz commented Jun 4, 2024 • edited

crbdev commented Jun 5, 2024 • edited

mrcasual commented May 21, 2024 •

edited

zackkatz commented May 27, 2024 •

edited by mrcasual

zackkatz commented May 27, 2024 •

edited by mrcasual

rafaehlers commented Jun 3, 2024 •

edited by zackkatz

mrcasual commented Jun 4, 2024 •

edited

zackkatz commented Jun 4, 2024 •

edited

crbdev commented Jun 5, 2024 •

edited