Do not run capture if metrics are empty.

Graylog2 · May 8, 2024 · c535e9c · c535e9c
1 parent 8fd0bca
commit c535e9c
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/...-server/src/main/java/org/graylog2/telemetry/scheduler/TelemetrySubmissionPeriodical.java b/...-server/src/main/java/org/graylog2/telemetry/scheduler/TelemetrySubmissionPeriodical.java
@@ -48,17 +48,17 @@ public TelemetrySubmissionPeriodical(TelemetryClient telemetryClient,
 
     @Override
     public void doRun() {
-        if (telemetryClient.isEnabled()) {
-            final var telemetryMetrics = metricsProviders.entrySet()
-                    .stream()
-                    .map(entry -> entry(entry.getKey(), entry.getValue().get()))
-                    .flatMap(entry -> entry.getValue().map(metrics -> entry(entry.getKey(), metrics)).stream())
-                    .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
-            try {
+        final var telemetryMetrics = metricsProviders.entrySet()
+                .stream()
+                .map(entry -> entry(entry.getKey(), entry.getValue().get()))
+                .flatMap(entry -> entry.getValue().map(metrics -> entry(entry.getKey(), metrics)).stream())
+                .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
+        try {
+            if (!telemetryMetrics.isEmpty()) {
                 telemetryClient.capture(telemetryMetrics);
-            } catch (Exception e) {
-                LOG.warn("Error while submitting telemetry: ", e);
             }
+        } catch (Exception e) {
+            LOG.warn("Error while submitting telemetry: ", e);
         }
     }