Do not throw error on dashboards with undeclared query parameters or on widget creation. #10536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently implemented a time range info for dashboard widgets. This PR is fixing a runtime error which occurred when no search types exist. This is the case when a filter with an undeclared parameter is being applied.
…`mockReturnValue`.`
linuspahl
force-pushed
the
dashboard-widgets-undeclared-parameter-error
branch
from
83a4ebb
to
65f2e52
Compare
linuspahl
changed the title
kmerz
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
We've recently implemented a time range info for dashboard widgets #10508. This PR is fixing a runtime error which occurred when no search types exist.
This is the case when a filter with an undeclared parameter is being applied.
It also fixes another runtime error which occurred after creating a new widget, because it was not yet listen in the search widget mapping.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: