Handle missing log collector for sidecar configurations. #14104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
fix/handle-empty-sidecar-os
branch
2 times, most recently
from
84e257b
to
9ae1b22
Compare
maxiadlovskii
approved these changes
Dec 2, 2022
linuspahl
reviewed
Dec 2, 2022
| <p><strong>Examples</strong></p> | ||
| <p> | ||
| Find sidecars that did not communicate with Graylog since a date:<br /> | ||
| <kbd>{'last_seen:<=2018-04-10'}</kbd><br /> |
| <OverlayTrigger trigger="click" rootClose placement="right" overlay={queryHelpPopover}> | ||
| <Button bsStyle="link"><Icon name="question-circle" /></Button> | ||
| </OverlayTrigger> | ||
| ); |
There was a problem hiding this comment.
Looks like we can define queryHelpPopover and queryHelp outside of the component.
dennisoelkers
force-pushed
the
fix/handle-empty-sidecar-os
branch
from
9ae1b22
to
5c787b6
Compare
dennisoelkers
force-pushed
the
fix/handle-empty-sidecar-os
branch
from
301d309
to
c3a60af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is fixing an issue when a sidecar configuration is referencing a log collector which is not present anymore. In this case, the Sidecar/Configuration page throws an exception and is not usable anymore.
It is currently unclear which steps can lead to a condition like this, because deleting a log collector from the frontend is not possible when it is referenced, but it was seen in the wild.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: