-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store Message receive and processing times #18150
Conversation
This seems to be more useful to create dashboards that show the processing performance of various Messages in Graylog.
@Graylog2/architecture I'm wondering if the timestamp fields are actually that useful. |
@mpfz0r I think the timestamp fields have their use cases. I agree that the duration is better for dashboards since we can't compute any values in our queries, AFAIK. We can store the duration as well. Let's call it The new field needs to be added to our index templates. If we don't want to wait again until everyone has the field, we need a migration step that adds the field to all active write indices. |
Doing that on the fly would involve a painless scripted query, not ideal, no.
Ack 👍
Is that necessary? The field will automatically be detected as a numerical value. |
@mpfz0r Ah right, it's not a date field like the other two. 👍 |
Storing `gl2_processing_duration_ms` as an integer is good enough and will save some space.
We don't use expected_gim_template7.json anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM processing time, processing duration & receiving time are all there
With #6022 we've started recording per-message receive and processing timestamps.
We didn't add those timestamps as message fields, because we wanted to make sure every index
has a proper datetime format mapping for those fields.
With a bit of delay 😏 we can finally store those fields on each Message.
Fixes #16284
Refs #16163
Forwarder support: https://github.com/Graylog2/graylog-plugin-enterprise/pull/6560