Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Stream details page #19342

Merged
merged 19 commits into from
Jun 7, 2024
Merged

Implement Stream details page #19342

merged 19 commits into from
Jun 7, 2024

Conversation

ousmaneo
Copy link
Contributor

@ousmaneo ousmaneo commented May 14, 2024 •
edited

/nocl
/jpd Graylog2/graylog-plugin-enterprise#7333

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ousmaneo ousmaneo marked this pull request as ready for review May 24, 2024 13:47
@ousmaneo ousmaneo force-pushed the stream-datawarehouse branch 2 times, most recently from 1b0616b to bd92fec Compare May 31, 2024 09:52
@kodjo-anipah kodjo-anipah changed the base branch from cold-tier to stream_based_dwh_config June 4, 2024 09:13
@gally47 gally47 self-requested a review June 6, 2024 09:39
gally47
gally47 reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Looking Good, I wrote some comments below.
I will test next.

graylog2-web-interface/src/components/streamrules/CreateStreamRuleButton.tsx Outdated Show resolved Hide resolved
graylog2-web-interface/src/components/streamrules/DetailsStreamRule.tsx Outdated Show resolved Hide resolved
graylog2-web-interface/src/components/streamrules/DetailsStreamRule.tsx Outdated Show resolved Hide resolved
...2-web-interface/src/components/streams/StreamDetails/StreamProcessingRoutingDestinations.tsx Outdated Show resolved Hide resolved
@ousmaneo ousmaneo requested a review from gally47 June 7, 2024 09:25
gally47
gally47 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ousmaneo ousmaneo merged commit f8a8a1b into stream_based_dwh_config Jun 7, 2024
6 checks passed
@ousmaneo ousmaneo deleted the stream-datawarehouse branch June 7, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gally47 gally47 gally47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ousmaneo @gally47 @kodjo-anipah