Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating search-related Mongo services away from MongoJack API. #19456

Merged
merged 23 commits into from
May 29, 2024
Merged

Migrating search-related Mongo services away from MongoJack API. #19456

merged 23 commits into from
May 29, 2024

Conversation

dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented May 27, 2024 •
edited
Loading

Description

Motivation and Context

/nocl No user-facing change.
/prd Graylog2/graylog-plugin-enterprise#7371

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers
Migrating search-related Mongo services away from MongoJack API.
a24e23e
@dennisoelkers
Improving test.
4d7b7fe
@dennisoelkers
Upsert if not present.
0f0fb2f
@dennisoelkers
Migrating DashboardsService.
c1c860d
@dennisoelkers
Migrating more services.
1178c87
@dennisoelkers
Migrating FavoritesService/DashboardService/ViewService.
a68eae4
@dennisoelkers
Merge branch 'master' into refactor/migrate-mongo-search-services
7a66f4c
@dennisoelkers
Improving test.
8756f66
@dennisoelkers
Turning variable local.
c31cd04
@dennisoelkers
Removing mongojack references.
3fee3be
@dennisoelkers
Merge remote-tracking branch 'origin/master' into refactor/migrate-mo…
8946229 
…ngo-search-services
@dennisoelkers
Migrating RecentActivityService.
a797c5c
@dennisoelkers
Migrating LastOpenedService.
4140b01
@dennisoelkers
Cleanups.
588d5a5
@dennisoelkers
Using MongoCollections#collection instead of #get.
d982fe9
@dennisoelkers
Cleaning up.
2db53c9
@dennisoelkers
Cleaning up construction of MongoUtils.
40841ab
@dennisoelkers
Cleaning up construction of MongoUtils.
4f4ca51
@dennisoelkers
Fixing up save vs. update.
2c90113
@thll thll mentioned this pull request May 28, 2024
Merged
@dennisoelkers dennisoelkers marked this pull request as ready for review May 28, 2024 13:46
@janheise janheise self-requested a review May 28, 2024 16:47
janheise
janheise approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@janheise janheise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dennisoelkers dennisoelkers merged commit bed47bc into master May 29, 2024
5 checks passed
@dennisoelkers dennisoelkers deleted the refactor/migrate-mongo-search-services branch May 29, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janheise janheise janheise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennisoelkers @janheise