Error handling reintroduced for preflight connection checks #19664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moesterheld
reviewed
Jun 19, 2024
graylog2-server/src/main/java/org/graylog2/storage/versionprobe/VersionProbe.java
Outdated
Show resolved
Hide resolved
graylog2-server/src/main/java/org/graylog2/storage/versionprobe/VersionProbeLogger.java
Show resolved
Hide resolved
ousmaneo
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Error handling reintroduced for preflight connection checks * logging delegate, code cleanup, test * fixed annotation * code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce error message propagation for preflight connection checks.
/nocl
Description
The connection check uses our existing, tried and trusted, VersionProbe to verify connection to a datanode opensearch. But the version probe had so far no mechanism to communicate errors, only to log them. New listener has been introduced. Default implementation logs errors, preflight implementation collects them and provides them as an error string, which is displayed in the frontend.
How Has This Been Tested?
Manually
Screenshots (if appropriate):
Types of changes
Checklist: