-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support setting time range in Copy From statement #4405
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4405 +/- ##
==========================================
- Coverage 84.97% 84.70% -0.27%
==========================================
Files 1076 1076
Lines 192585 192669 +84
==========================================
- Hits 163653 163205 -448
- Misses 28932 29464 +532 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM. Please take a look @fengjiachun @WenyXu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice done🚀
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Resolve #3511
What's changed and what's your intention?
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Reuse the time range specified in the WITH clause and ensure the data can be filtered based on the 'ts' column. Hence,
Copy table x from datasource with (start_time='2022-06-15 07:02:37', end_time='2022-06-15 07:02:38');
statement should work properly.All work based filter_record_batch in file:
greptimedb/src/common/recordbatch/src/adapter.rs
Lines 94 to 95 in 2ae2a66
Checklist