Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: larger stack size in debug mode #4521

Merged
merged 8 commits into from
Aug 9, 2024
Merged

fix: larger stack size in debug mode #4521

merged 8 commits into from
Aug 9, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Aug 7, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

set larger stack size for debug mode, so it doesn't overflow for deep recursive functions. After setting this, cargo sqlness doesn't overflow in windows(it can relably reproduce overflow before this fix)

https://github.com/GreptimeTeam/greptimedb/actions/runs/10261340360/job/28388920598

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@discord9 discord9 requested a review from a team as a code owner August 7, 2024 04:30
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 7, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Aug 7, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 84.98%. Comparing base (a75cfaa) to head (e2131b2).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4521      +/-   ##
==========================================
- Coverage   85.02%   84.98%   -0.04%     
==========================================
  Files        1084     1084              
  Lines      193947   193972      +25     
==========================================
- Hits       164903   164854      -49     
- Misses      29044    29118      +74

evenyag
evenyag reviewed Aug 7, 2024
View reviewed changes
src/cmd/src/bin/greptime.rs Show resolved Hide resolved
src/cmd/src/bin/greptime.rs Outdated Show resolved Hide resolved
evenyag
evenyag reviewed Aug 7, 2024
View reviewed changes
src/cmd/src/bin/greptime.rs Outdated Show resolved Hide resolved
evenyag
evenyag reviewed Aug 7, 2024
View reviewed changes
src/cmd/src/bin/greptime.rs Outdated Show resolved Hide resolved
evenyag
evenyag approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

src/cmd/src/bin/greptime.rs Outdated Show resolved Hide resolved
src/cmd/src/error.rs Show resolved Hide resolved
fengjiachun
fengjiachun approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@discord9 discord9 added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit 8f3293d Aug 9, 2024
32 checks passed
@discord9 discord9 deleted the fix_stack branch August 9, 2024 07:20
CookiePieWw pushed a commit to CookiePieWw/greptimedb that referenced this pull request Sep 17, 2024
@discord9 @CookiePieWw
fix: larger stack size in debug mode (GreptimeTeam#4521)
f0b6886 
* fix: larger stack size in debug mode

* chore: typo

* chore: clippy

* chore: per review

* chore: rename thread

* chore: per review

* refactor: better looking cfg

* chore: async main entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag evenyag approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@discord9 @fengjiachun @evenyag