changes to move gles2 shader header file generation into external script #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipt instead of internal python logic. This should avoid the race condition previously found when running parallel builds
|
Thank you! I want to ask (out of politeness and legalise): can i push this commit together with my changes to the Godot repo under the MIT licence? |
|
yes. You'll want to add similar changes in the other platforms detect.py. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes to move gles2 shader header file generation into external script instead of internal python logic. This should avoid the race condition previously found when running parallel builds.
Note that these changes resolve the race conditions for these files, but building with -j6 revealed similar issue with other generated header files. Likely you'll need to do this for all such logic.
Also note that the changes to platforms/windows/detect.py should be propagated to all the other platforms which specify the GLSL120GLES builder.