Change groovy-mode to be a standalone mode. #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is set automatically by MELPA.
* Ensures we highlight all keywords correctly. Fixes Groovy-Emacs-Modes#33 and Groovy-Emacs-Modes#26. We also highlight `println` and `print` for consistency with other modes, such as python-mode. * Highlight triple-quoted strings correctly. Fixes Groovy-Emacs-Modes#29. * Ensure we consistently highlight variable declarations (fixes Groovy-Emacs-Modes#27) and variable assignments. * Highlights `it` as a variable unconditionally.
|
I think for the moment I should merge this into a new branch in this mainline repository. People willing to test the mode (including me) can then use the branch rather than master. This would entail me merging this pull request on my clone, pushing to mainline, and then apparently rejecting this pull request. Does that make sense and seem reasonable? |
|
Yep, that makes sense, thanks. |
Wilfred
changed the title
Wilfred
force-pushed
the
standalone_mode
branch
from
f652389
to
1f3872e
Compare
|
As agreed I have created a new branch in this mainline repository with this changeset in and so I am rejecting this pull request (since it is posted against master). I will amend the README.md in master and post an email to the Groovy mailing list to see if we can get people to use the new version and report back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #26 (comment) I'm having a go at modifying groovy-mode so it doesn't depend on cc-mode.
This has fixed all of the open highlighting bugs in this repo, and it should fix #11 too.
Let me know what you think.
Edit: now includes indentation logic.