Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address minor accessibility issues: Image elements do not have [alt] attributes #3561

Merged
merged 9 commits into from
Jan 17, 2024

Conversation

CloCkWeRX
Copy link
Collaborator

@CloCkWeRX CloCkWeRX commented Jan 14, 2024

Part of #2067

@CloCkWeRX CloCkWeRX changed the title Address minor accessibility issues Address minor accessibility issues: Image elements do not have [alt] attributes Jan 14, 2024
@CloCkWeRX CloCkWeRX mentioned this pull request Jan 14, 2024
@CloCkWeRX CloCkWeRX marked this pull request as ready for review January 14, 2024 13:46
@CloCkWeRX
Copy link
Collaborator Author

May split this into smaller changes if test failures are too plentiful

@CloCkWeRX
Copy link
Collaborator Author

Hmm. Need to look at this more. I don't quite understand how we have failures things like a harvest.crop.name call being a nilclass error, as we seem to have presence validations and the factories are set up as expected.

@CloCkWeRX CloCkWeRX merged commit 78eaf0b into dev Jan 17, 2024
6 checks passed
@CloCkWeRX CloCkWeRX deleted the accessibility branch January 17, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant