Merge master into gsdevkit branch #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 11, 2021 13:33
…Utf8CodecStream from the TextConverter-based code
- do not fall back to `utf8Decoded` message in `GRPharoUtf8Codec>>decode:`
…d the GRDeprecatedUtf8CodecStream class>>initialize method that errored during code load due to the TextConverter not working anymore.
Use ZnUTF8Encoder instead of TextConverter in Pharo9+
|
@jbrichau looks like pharo-10 is consistently failing ... is that expected or ??? |
|
@dalehenrich yes, it’s “preview” as Metacello’s platform attributes in Pharo 10 are still saying it’s Pharo 9. I raised the question on Discord when that is going to change because I need it to make a difference for Grease. I now notice I did not include Pharo10 correctly in the ci.yml to make it ignore failure. If you prefer, you can wait to merge until I adapt that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to version 1.8.0 to keep the diff in control.
Changes: https://github.com/SeasideSt/Grease/releases/tag/v1.8.0