Some minor bugfixes #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old version always returns the last element instead of null at the end.
The old version did not compare all possible leaf pairs.
As the similarity between two entries is not unique it is possible that across different runs of gumtree on the same changed file the order in ambiguousList changes. This can cause a change in the mapping. The added ID criteria enforces an absolute order. Of course other absolute orders would also be valid.
In the publication, leaves have height 1, in the source code they have height 0. MIN_HEIGHT=1 also leads to better results than MIN_HEIGHT=2.
|
Hi! Thanks for the bug fixes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the fixes are for ChangeDistiller.
And you really should consider adjusting the default MIN_HEIGHT ;).