Skip to content

Conversation

monperrus
Copy link
Contributor

@monperrus monperrus commented Feb 2, 2018

when optimizing new hard cases in gumtree-spoon-ast-diff, I realized that the default of min similarity is far too low. A value of 0.5 and 0.6 gives much smaller and cleaner diffs.

WDYT?

(What will CI say? Travis OK, no test breaks.)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.029% when pulling f8e475b on monperrus:fix-sim into f196c52 on GumTreeDiff:develop.

@jrfaller
Copy link
Member

jrfaller commented Feb 2, 2018

Nice! Thanks for the tip, this goes into develop.

@jrfaller jrfaller merged commit 08c8061 into GumTreeDiff:develop Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants