support setting specific charset for decoding source file or stream #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current charset used for decoding and encoding is hard-coded 'UTF-8'. This patch enables setting the charset used to decode source file from system properties. Other i/o operations, such as writing temporary file and reading output of external tools, still use hard-coded 'UTF-8' as the default charset.
Please review this patch.
BTW, the charset of source files can be changed in some revisions, actually. It will be better to support setting source file charset and destination file charset separately. However, it is not trivial to achieve. Because only the client knows which charset should be used for decoding in this situation, some core APIs, including
Generators.getTree(String file)
andGenerators.getTree(String generator, String file)
, and the caller of them may be required modification.