Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add portuguese translation #134

Merged
merged 4 commits into from
Apr 16, 2023
Merged

Add portuguese translation #134

merged 4 commits into from
Apr 16, 2023

Conversation

franciscoBSalgueiro
Copy link
Contributor

No description provided.

@vrmiguel vrmiguel mentioned this pull request Apr 13, 2023
Closed
@GyulyVGC GyulyVGC added the translation User interface translation label Apr 13, 2023
@GyulyVGC
Copy link
Owner

A PR for Brazilian Portuguese has also been opened (#136).
Is it meaningful in your opinion to have both languages featured or you guys can agree on a single language? Do they differ substantially?

@franciscoBSalgueiro
Copy link
Contributor Author

It's the same language, so any portuguese speaking person would be able to read both. That being said, you can definitely tell one was written by a Brazilian and another by a Portuguese. I've seen some apps have both a pt_PT and pt_BR translation, but if you only want to have one, I think any of them would work.

@GyulyVGC
Copy link
Owner

If standard Portuguese is also comprehensible by Brazilians, I'd prefer to keep only one.
I kindly ask to @vrmiguel to review this PT translation and let me know if some term is not clear.
If something is not clear, may you find a version that suits both?
Thanks in advance guys!

@GyulyVGC GyulyVGC mentioned this pull request Apr 13, 2023
Open
@GyulyVGC
Copy link
Owner

Since #136 has been closed, I'll proceed merging this PR!

@GyulyVGC GyulyVGC added this to the v1.1.4 milestone Apr 15, 2023
@GyulyVGC GyulyVGC merged commit 44132fa into GyulyVGC:main Apr 16, 2023
@GyulyVGC
Copy link
Owner

@all-contributors please add @franciscoBSalgueiro for translation

@allcontributors allcontributors bot mentioned this pull request Apr 16, 2023
Merged
@allcontributors
Copy link
Contributor

@GyulyVGC

I've put up a pull request to add @franciscoBSalgueiro! 🎉

@chuanchan1116 chuanchan1116 mentioned this pull request Apr 19, 2023
Merged
GyulyVGC added a commit that referenced this pull request May 7, 2023
@GyulyVGC
Merge pull request #134 from franciscoBSalgueiro/main
156d834 
Add portuguese translation
@GyulyVGC GyulyVGC mentioned this pull request Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GyulyVGC GyulyVGC GyulyVGC approved these changes

Assignees
No one assigned
Labels
translation User interface translation
Projects
None yet
Milestone
v1.1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscoBSalgueiro @GyulyVGC