Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Russian translation #151

Merged
merged 3 commits into from
Apr 16, 2023
Merged

feat: add Russian translation #151

merged 3 commits into from
Apr 16, 2023

Conversation

amarao
Copy link
Contributor

@amarao amarao commented Apr 15, 2023

N.B. It's broken and I can't understand why. Letters 'Р' and 'ы' are not displayed. Please help, if you can.

image

@GyulyVGC
Copy link
Owner

N.B. It's broken and I can't understand why. Letters 'Р' and 'ы' are not displayed. Please help, if you can.

Don't worry, I'll add the missing characters to the font file.
Thank you very much for the translation 🙏

@GyulyVGC
Copy link
Owner

Please, if you can let me know if everything looks good now

@GyulyVGC GyulyVGC added this to the v1.1.4 milestone Apr 15, 2023
@amarao
Copy link
Contributor Author

amarao commented Apr 15, 2023

Yes, it looks nice! Even ё (which was also missing) is present. Thank you!

@amarao
Copy link
Contributor Author

amarao commented Apr 15, 2023

Btw, I feel that manual letter update is a bit ... too manual? May be it can just grab all letters from the translation source file (May be even not at Rust level, just list of unique characters in the text file with .rs extension).

@GyulyVGC
Copy link
Owner

Btw, I feel that manual letter update is a bit ... too manual? May be it can just grab all letters from the translation source file (May be even not at Rust level, just list of unique characters in the text file with .rs extension).

Yep, it's exactly what I was meaning with manual.
I grep all the characters of the src folder and add them from the full font into the subset font with a command line utility.

@GyulyVGC GyulyVGC merged commit fe8e378 into GyulyVGC:main Apr 16, 2023
@GyulyVGC
Copy link
Owner

@all-contributors please add @amarao for translation

@allcontributors
Copy link
Contributor

@GyulyVGC

I've put up a pull request to add @amarao! 🎉

GyulyVGC added a commit that referenced this pull request May 7, 2023
feat: add Russian translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation User interface translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants