-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Persian translation #158
Added Persian translation #158
Conversation
Thanks for your contribution. Just a few notes:
|
Yes, those fonts won't work for Persian and some other languages.
No single font supports all characters. Merging them wouldn't help reduce the volume, nor is it a straightforward process. Instead, we could consider loading them on-demand from a CDN during runtime, rather than embedding them directly into the executable file. Do you have any suggestions? |
On second thought, what if we don't use a custom font at all, but rely on a widely-used, pre-installed default font on the client side? Would Iced support system fonts just by specifying their names? |
I don't think so... until iced will not support font fallback I think there is little we can do. |
I addressed the issue with the executable size and kept the original font as a fallback. In near future, I tend to assist with packaging the app for more platforms and installer tools. At that point, we may opt to install the custom fonts during setup, considering the approaches taken by traditional desktop apps, but I don't like the idea of installing other language fonts on the client's system. I still like the idea of relying on pre-installed fonts if we can manage to display the language names on the settings page whether the language font exists or not, perhaps by bundling a limited-character custom font. However, this method requires a fallback solution, such as the dynamic loading that I just introduced in this PR, so it can handle unexpected selections of curious minds. |
I'll give a more in-depth look to this PR in the next few days. Also, it'd be very appreciated if you could help with packaging. |
I understand... But traditionally, when the application didn't adopt system fonts, custom fonts have either been bundled within the executable or included in the accompanying resource files. Loading fonts from CDN however, is a common practice in hybrid applications. Alternatively, we could merge glyphs from other language fonts into the subset font that you have already created since only a few additional characters would be introduced, although we may encounter some technical difficulties in the process. Nonetheless, as you suggested, we can only include an additional Arabic script font for both Arabic & Persian since the original font works for the rest of the current selection. This approach should work well for most non-East Asian languages, which typically have lighter font sizes compared to East Asian languages. However, for languages with larger font sizes, font subsetting might be used to reduce file sizes, as you are already familiar with this technique.
Sure, that was actually my main objective. I can certainly help with the other aspects as well. |
Sorry for the delays, but I'm currently busy implementing new features for the next version. Tomorrow I'll merge the font file with Arabic characters in the full font file and I'll subset it keeping only the used glyphs. |
I've added the arabic glyphs to the original font files. |
@all-contributors please add @4r7if3x for translation. |
I've put up a pull request to add @4r7if3x! 🎉 |
@4r7if3x are you still willing to help packaging the app? |
Sure! Please let me know about the deadline as well. If you need to discuss something personally, you can always reach out via email. |
This PR addresses a few improvements in the font and language support:
Change Log:
Known Issues: