Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Romanian translation v1.2 #241

Merged
merged 2 commits into from
Jun 3, 2023
Merged

added Romanian translation v1.2 #241

merged 2 commits into from
Jun 3, 2023

Conversation

ervinpopescu
Copy link
Contributor

New characters need to be added in the font @GyulyVGC :) One question, the table header doesn't need to be updated?
image

@GyulyVGC
Copy link
Owner

GyulyVGC commented Jun 3, 2023 •
edited
Loading

Thank you very much for the update.
I'll add the missing characters.

For what concerns the table header, I don't translate it yet because of #63.
Translating the table header means having the headings of different lengths depending on the language, which could possibly cause a dealignment.
I have to implement a different mechanism for the table (for the moment it's just made of aligned ASCII characters).

@GyulyVGC GyulyVGC added the translation User interface translation label Jun 3, 2023
@GyulyVGC GyulyVGC added this to the v1.2.1 milestone Jun 3, 2023
@GyulyVGC GyulyVGC mentioned this pull request Jun 3, 2023
Open
@GyulyVGC GyulyVGC merged commit 6eb48d5 into GyulyVGC:main Jun 3, 2023
@p-linnane p-linnane mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GyulyVGC GyulyVGC GyulyVGC approved these changes

Assignees
No one assigned
Labels
translation User interface translation
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ervinpopescu @GyulyVGC