Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Iced 0.10 #324

Merged
merged 19 commits into from
Aug 3, 2023
Merged

Migration to Iced 0.10 #324

merged 19 commits into from
Aug 3, 2023

Conversation

GyulyVGC
Copy link
Owner

@GyulyVGC GyulyVGC commented Jul 30, 2023

This PR migrates Sniffnet to Iced 0.10, fixing associated changes and introducing new features available:

  • Now the graphical renderer is chosen at runtime and a fallback one (tiny-skia) will be used if the default one (wgpu) crashes
  • Added option to set different types of color gradients for each of the available themes
  • Improved tabs and modals layout using the new BorderRadius capabilities, that allow to specify a different radius for each of the angles
  • Changed scrollable style to make scrollable render properly also with tiny-skia
  • Unfortunately, Persian translation has been removed since RTL languages are unsupported and may crash the app

@GyulyVGC GyulyVGC added this to the v1.2.2 milestone Jul 30, 2023
@GyulyVGC GyulyVGC added enhancement New feature, request, or improvement renderer Problem related to the renderer used by the GUI library dependencies Pull requests that update a dependency file design Styling and appearance labels Jul 30, 2023
@GyulyVGC
Copy link
Owner Author

GyulyVGC commented Jul 31, 2023

@4r7if3x hey man!

Iced has finally published the release featuring a new software renderer as well as font fallback.

  • Negative news first:
    Unfortunately, I had to comment (80a8871) Persian since the situation for RTL languages got even worse actually (can cause panic in some circumstances and are completely messed up, Crash with Arabic text in PickList iced-rs/iced#1981)
  • On the bright side:
    Now a CPU-only renderer based on tiny-skia is available and is claimed to run "everywhere"; glow has been removed and by default wgpu is still uses, and tiny-skia is used as a fall-back in case of wgpu problems.
    tiny-skia is a bit slow in debug mode but works great on my hardware in release mode.
    IIRC, you said you had a PC which doesn't support wgpu. Can you confirm it correctly displays everything with tiny-skia?
    To note that tiny-skia can also be tested by disabling iced default features (that include wgpu)

@GyulyVGC GyulyVGC merged commit 32a49bd into main Aug 3, 2023
6 checks passed
@GyulyVGC GyulyVGC deleted the iced-0.10 branch August 3, 2023 11:17
@GyulyVGC GyulyVGC mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file design Styling and appearance enhancement New feature, request, or improvement renderer Problem related to the renderer used by the GUI library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant