Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful termination #420

Merged
merged 7 commits into from
Dec 30, 2023
Merged

Graceful termination #420

merged 7 commits into from
Dec 30, 2023

Conversation

GyulyVGC
Copy link
Owner

Adds support for graceful termination in presence of SIGINT, SIGTERM, and SIGHUP.

Sniffnet needs to save some configurations (settings, window properties, and name of last sniffed device) before closing.

Gracefully terminating the application when the aforementioned signals are received means being able to save such configurations when the user quits Sniffnet in an unconventional way (e.g., by pressing ctrl + C in terminal, by sending kill command, or by closing the terminal that launched the execution).

@GyulyVGC GyulyVGC added the enhancement New feature, request, or improvement label Dec 27, 2023
@GyulyVGC GyulyVGC added this to the v1.3.0 milestone Dec 27, 2023
@GyulyVGC GyulyVGC mentioned this pull request Dec 27, 2023
1 task
Copy link
Owner Author

@GyulyVGC GyulyVGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@GyulyVGC GyulyVGC merged commit f61b4e3 into main Dec 30, 2023
6 checks passed
@GyulyVGC GyulyVGC deleted the graceful-termination branch December 30, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, request, or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant