Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcpkg upgrade #994

Merged
merged 3 commits into from Oct 2, 2021
Merged

vcpkg upgrade #994

merged 3 commits into from Oct 2, 2021

Conversation

Hoikas
Copy link
Member

@Hoikas Hoikas commented Oct 2, 2021

Routine vcpkg upgrade with some not-so-routine fixes. This pulls down a patch I submitted to fix the python3 build on GHA windows-2019 runners due to what appears to be a bug in the Windows SDK. Also, we now use the newfangled VCPKG_DISABLE_COMPILER_TRACKING to avoid including the hash of cl.exe in the binarycache. So, hopefully, folks will actually download the libraries from GitHub Packages now, instead of rebuilding them from scratch because they have a slightly newer or older VS.

Before merging:

  • Check that python39.dll is present in the artifacts.
  • Ensure all 3ds Max builds succeed.

Updated Libraries:

  • asio 1.19.2
  • curl 7.79.1
  • libjpeg-tubo 2.0.6#1
  • libvpx 1.10.0#2
  • openssl 1.1.1l#1
  • Python 3.9.7#1
  • sqlite3 3.36.0
  • zlib 1.2.11#12

Updated libraries:
- asio 1.19.2
- curl 7.79.1
- libjpeg-tubo 2.0.6#1
- libvpx 1.10.0#2
- openssl 1.1.1l#1
- Python 3.9.7#1
- sqlite3 3.36.0
- zlib 1.2.11#12
With the most recent update of vcpkg-tool, vcpkg will now allow us to
skip including the hash of cl.exe with the binary cache. This means that
minor compiler revisions eg 16.10.1 -> 16.10.2 will not invalidate the
cache. So, downstream users will more likely be able to download the
libraries from CI.

This decision may need to be revisited when Microsoft breaks ABI
compatbility in vNext. However, per the STL repo, this has been delayed
indefinitely. (NOTE: Visual Studio 2022 is not vNext).
I'm tired of receiving emails about the token format being out of date
when CI runs after several days of inactivity.
@Hoikas
Copy link
Member Author

Hoikas commented Oct 2, 2021

The binary cache hashes are still showing a mismatch from my local build and CI, but I think that may be because my CMake version does not match what's on CI. I don't think that should block this PR, though.

@Hoikas Hoikas marked this pull request as ready for review October 2, 2021 02:58
@Hoikas Hoikas merged commit f7faec6 into H-uru:master Oct 2, 2021
@Hoikas Hoikas deleted the vcpkg-upgrade branch October 2, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants