vcpkg upgrade #994
Merged
vcpkg upgrade #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated libraries: - asio 1.19.2 - curl 7.79.1 - libjpeg-tubo 2.0.6#1 - libvpx 1.10.0#2 - openssl 1.1.1l#1 - Python 3.9.7#1 - sqlite3 3.36.0 - zlib 1.2.11#12
With the most recent update of vcpkg-tool, vcpkg will now allow us to skip including the hash of cl.exe with the binary cache. This means that minor compiler revisions eg 16.10.1 -> 16.10.2 will not invalidate the cache. So, downstream users will more likely be able to download the libraries from CI. This decision may need to be revisited when Microsoft breaks ABI compatbility in vNext. However, per the STL repo, this has been delayed indefinitely. (NOTE: Visual Studio 2022 is not vNext).
I'm tired of receiving emails about the token format being out of date when CI runs after several days of inactivity.
Member
Author
|
The binary cache hashes are still showing a mismatch from my local build and CI, but I think that may be because my CMake version does not match what's on CI. I don't think that should block this PR, though. |
dpogue
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routine vcpkg upgrade with some not-so-routine fixes. This pulls down a patch I submitted to fix the python3 build on GHA windows-2019 runners due to what appears to be a bug in the Windows SDK. Also, we now use the newfangled
VCPKG_DISABLE_COMPILER_TRACKINGto avoid including the hash of cl.exe in the binarycache. So, hopefully, folks will actually download the libraries from GitHub Packages now, instead of rebuilding them from scratch because they have a slightly newer or older VS.Before merging:
Updated Libraries: