Properly skip over convex meshes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might want to work on making the coding style consistent with the rest of libHSPlasma. Zrax isn't going to accept patches that contradict the predominant style. |
|
|
||
| void PXCookedData::readConvexMesh(hsStream* S, plGenericPhysical* fPhysical) |
There was a problem hiding this comment.
fPhysical? that's not a class member...
There was a problem hiding this comment.
fixed in updated patchset
…Data class (which did not gain anything from being instanciated)
….e. the size-read difference warnings are gone!
|
I think I addressed the coding style issue with the updated patchset. At least, I found nothing else which stood out... I could not find a coding style documentation, either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements properly reading all the bytes belonging to a convex mesh - without knowing what they mean though. After applying this, there are no more size-read differences for all MOUL files.