Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Save Files #1

Closed
H4kor opened this issue Dec 9, 2023 · 1 comment
Closed

Optimize Save Files #1

H4kor opened this issue Dec 9, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@H4kor
Copy link
Owner

H4kor commented Dec 9, 2023 •
edited
Loading

Currently each key stroke in a notes or name field creates one entry in the save file. This leads to large save files and long load times for large dungeons (with lots of editing).

Options:

  • Better command emission from edit components to bundle changes
  • Instead adding the whole text to each command, only add a diff (sounds to complex for the moment)
  • Better persistence code, which omits commands with no effect
@H4kor H4kor added the enhancement New feature or request label Dec 9, 2023
@H4kor
Copy link
Owner Author

H4kor commented Dec 22, 2023

addtionally: unconnect observers and emit a event after rebuild to refresh widgets

H4kor added a commit that referenced this issue Dec 22, 2023
@H4kor
silend apply commands on load and undo for significant performance bo…
1688d8f 
…ost. #1
@H4kor H4kor closed this as completed in a064fc7 Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@H4kor