-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to plot waterfalls of delay spectra #158
Conversation
Thanks for getting a start on this, its much-needed! One comment is, I'm not sure if its right to plot a single waterfall containing multiple baseline-pairs. It seems a little odd to do that, and perhaps is just confusing. Seems like when we say "waterfall", we should mean a single baseline-pair with a non-zero time axis which makes it a heatmap. If we want to make multiple blpair heatmaps, instead of concatenating them into a single heatmap, we should be making multiple subplots... I can make this edit if you are ok w/ it and push to the branch |
The idea was that this could eventually be used to make wedge plots too, which is why I allowed it to take multiple blpairs as an argument. It's not quite there yet though (e.g. it doesn't do the necessary averaging for you), so I agree more work is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This stuff looks good to me. Phil let me know if you have any comments on the edits. I rebased the branch of master already, so should be good to merge once you've had a look.
Also about your comment on wedge plots: I think wedge plots are fundamentally different though. We can't make a "wedge-waterfall" because you've already used up your two heatmap axes for k_perp and k_parallel. A "waterfall" to me implies a time and spectral axes, so if we want to plot wedges, we should probably just make a new function (delay_wedge
) to do that.
Is there an option to allow all the subplots to be on a common colour scale? |
@acliu yes there is. you can specify the |
@philbull the other important change is that I enforced |
Plot delay spectra ordered by time or baseline-pair. Solves #155.