Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis install pyuvdata commit 9c94be0366eb41692f55 #167

Merged
merged 3 commits into from
Aug 14, 2018

Conversation

nkern
Copy link
Member

@nkern nkern commented Aug 9, 2018

currently HEAD of master (8/9/2018)

@nkern nkern requested a review from philbull August 9, 2018 10:13
@ghost ghost assigned nkern Aug 9, 2018
@ghost ghost added the in progress label Aug 9, 2018
@coveralls
Copy link

coveralls commented Aug 9, 2018

Coverage Status

Coverage remained the same at 96.536% when pulling 4cb70bd on travis_pyuvdata_install into 523ec22 on master.

@ghost ghost assigned philbull Aug 10, 2018
@philbull
Copy link
Collaborator

@nkern I've made this a bit fancier by making Travis build against two versions of pyuvdata: (1) a commit that we specify; and (2) the current version of master. So it will tell us if recent updates to pyuvdata break things for us.

@nkern
Copy link
Member Author

nkern commented Aug 10, 2018

@philbull awesome! I'm happy w/ that so long travis knows not to fail a PR check if the build against master breaks, but that's not what seems what will happen. Do you know how to specify our PR checks?

@philbull
Copy link
Collaborator

@nkern I added a line to the Travis config that (hopefully) makes it so that issues with pyuvdata won't block PRs.

Copy link
Collaborator

@philbull philbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.

@nkern nkern merged commit 6c8b231 into master Aug 14, 2018
@nkern nkern deleted the travis_pyuvdata_install branch August 14, 2018 00:46
@ghost ghost removed the in progress label Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants