Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial load from container.get_pspec #218

Merged
merged 6 commits into from
Aug 27, 2019
Merged

Conversation

nkern
Copy link
Member

@nkern nkern commented Aug 25, 2019

Principally, this PR enables partial UVPSpec loading from within a PSpecContainer.get_pspec method.

Additionally, I've added a few minor things that I've just been meaning to get in:
• Makes all module imports relative imports (thought this was already done?)
• buries matplotlib imports in plot.py to the functions
• adds exclude_cross_bls kwarg to utils.construct_blpairs, which will exclude a bl crossed with a different bl (somewhat analogous to exclude_auto_bls but with flipped functionality
• adds UVPSpec.get_polpairs() method to get all pol-pairs in a uvp object.

@nkern nkern requested a review from philbull August 25, 2019 21:17
@coveralls
Copy link

coveralls commented Aug 25, 2019

Coverage Status

Coverage increased (+0.008%) to 96.828% when pulling 0aeb845 on partial_load_from_container into dbc2384 on master.

Copy link
Collaborator

@philbull philbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Ready to merge!

@nkern nkern merged commit 87c6d0a into master Aug 27, 2019
@nkern nkern deleted the partial_load_from_container branch August 27, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants