Proper combining of nsamples for psuedo-Stokes to preserve proper noise variance #392
Conversation
…serve proper noise variance"" This reverts commit 36b1e7d.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
=========================================
+ Coverage 0 95.99% +95.99%
=========================================
Files 0 17 +17
Lines 0 6118 +6118
=========================================
+ Hits 0 5873 +5873
- Misses 0 245 +245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
The simulations show that it's clearly predicting the right variance, and moreover it's all mathematically sound. While I agree that it doesn't quite agree with the definition of nsamples, it's the right thing to do for variance prediction and that is all we use nsamples for in pspec as far as I know.
I've done a quick check to see that if one or both of these entries are 0.0 (that is, a numpy array with 0.0 as entries, not the builtin float 0.0), this syntax returns 0.0, which is as desired. Additionally nan's beget nans.
I approve.
This PR resolved #391