Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests re. future array shapes and ensured compatibility in utils #397

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

adeliegorce
Copy link
Contributor

Following @JianrongTan's issue #396 , this PR

  1. Fixes a backward compatibility issue in utils.uvd_to_Tsys which raised an error when the UVData file used has future_array_shapes=False
  2. Adds tests to test_utils to ensure backwards compatibility of the code with and without future array shapes.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.17%. Comparing base (a5f458f) to head (01857a8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   95.99%   96.17%   +0.17%     
==========================================
  Files          17       17              
  Lines        6118     6118              
==========================================
+ Hits         5873     5884      +11     
+ Misses        245      234      -11     
Flag Coverage Δ
unittests 96.17% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@JianrongTan JianrongTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. Thanks @adeliegorce!

@JianrongTan JianrongTan merged commit cd12a55 into main Mar 17, 2024
11 checks passed
@adeliegorce adeliegorce deleted the future-array-shapes-bug branch March 18, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of backward compatibility for non-future_array_shape in utils.uvd_to_Tsys
2 participants