Repository navigation
Community pre-validation batch — 43 PRs checked; 35 merged (Oct 31) #2217
Replies: 8 comments
|
Two more from the #2289–#2294 batch:
Also independently verified two community PRs that are waiting on workflow approval:
|
Nov 1 queue update (~10:00 UTC)No merges since the Oct 31 11:28 UTC batch. The open queue is now 141 issues / 123 PRs; the increase is mostly the Windows-compatibility series (#2266–#2286) and five detailed bug reports (#2289–#2294). Still clean from the Oct 31 batch: #2246, #2251, #2252, #2253, #2254. #2257 (@Zhi-Xiang-Guo) is also green and fixes #2255; my #2264 was closed as its duplicate. New fixes opened this morning (CI running, no failures yet):
Review notes posted:
Still untouched: #2292 (backfill marks a failed attribution as attempted, so it never retries; needs a retry/status design plus manual binding UI) and the remaining UX asks in #2291 (global side-chat entry, standalone side chats). |
|
One more feature PR from today's request:
|
Nov 2 update (~09:00 UTC)No merges since the Oct 31 11:28 UTC batch; the queue is now 136 issues / 168 PRs. Most of the growth is new contributor PRs, not regressions. Two new fixes from today's triage:
Also from the notification batch:
All 15 of my open PRs are CLEAN. |
Nov 2, 22:15 UTC — the queue is blocked on CI approvals, not on codeOpen queue: 145 issues / 193 PRs. Before reviewing anything, there is one mechanical bottleneck worth clearing. 39 open PRs have all three PR workflows in
The rest of the blocked set, oldest first:
A few of these have been waiting since Oct 5 (#1785), Oct 19 (#1995) and Oct 21 (#2010). Approving a run does not endorse the PR; it only lets CI say whether it is reviewable. 13 older PRs have no workflow runs at all (mostly pre-dating the current workflows or path-filtered): Once the batch is approved, the queue becomes readable by CI state: 141 PRs already have real results, and the mergeable subset can be triaged from checks instead of guessed. If the whole batch is too much, the small blocked fixes firstThese are under 150 changed lines and at most five files, so a green CI run is quick to judge:
Two size outliers in the blocked set: Three new contributions from today
All three are open from a fork with existing merged PRs, so their checks run without approval. All three are already CLEAN (#2396 22 checks, #2397 24, #2398 22). Landing #2397 first makes the approval batch cheaper: a newer push cancels the superseded matrix instead of leaving it in the queue. |
|
Follow-up on the P0 hotfix review:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
I spent some time pre-validating the open PR queue so the maintainer can merge in batches instead of re-running the same checks. This is a community snapshot, not a request for action — every PR below has the exact command and result in its review comment.
Maintainer checklist (Oct 31)
CLEAN PRs ready to merge — all checks green, no failures:
Issues already fixed on
dev— ready to close:$(integration merge7b307357d):(fix(i18n): stop splitting translation keys on ":" #2178)dir="auto"rendering (feat(web): render right-to-left text correctly with per-block dir=auto #2221)%and_in a query as SQL LIKE wildcards #2214 — MarginNote LIKE wildcards (fix(capabilities): match LIKE wildcards literally in the MarginNote store (#2214) #2215)mastery_assessis refused as "teaching slice", so the tutor re-quizzes forever #2070 — Mastery concept objectives (fix: Mastery Path concept objectives can never pass — everymastery_assessis refused as "teaching slice", so the tuto #2103)budgetchunks whenever overlap_ratio > 0 #2111 — chunk budget with overlap (Integrate reviewed October PRs with correctness and compatibility fixes #2126 /e1c05b852)/api/auth/is_first_user在认证关闭时的返回值 #2175 —is_first_userwhen auth is disabled (answered by design)supports_vision, backend never sends it #2037 — image-description model dropdown (fix(settings): let a declared vision model drive image description #2039)share_mastery_historyrewrote sent history (fix(mastery): keep shared history prefixes stable for prompt caching #2085)d02fb9850)Batch 3 (older issues) — 11 fixed, 12 feature-implemented, 5 questions, 1 superseded; individual comments posted:
#1240, #1228, #1223, #1220, #1215, #745, #621, #473, #431, #429, #199, #1209, #1130, #1109, #992, #971, #916, #725, #684, #661, #613, #375, #304, #655, #612, #486, #440, #401, #1238.
Oct 31 merge batch — final status
By 11:28 UTC, 35 of the 43 PRs in this list are merged, including #2203, #2204, #2206 and #2216. The remaining 8:
dev; readydev; readydev; readytests/utils/test_document_images.py(new OMML tests from #2163); source merges cleanlye1c05b852(integrated via #2126); rebasing would add nothingimport timeOther outcomes:
devf756f371: full pytest 25 failed / 11,693 passed; all 25 reproduce on pre-batch40c051b, so none is a regression from the batch.npm run test:node1318 passed; typecheck clean.Blocked
verify_sources()does not flush. Needs a processed-since-save counter and a regression test.recovery.pycallstime.time()withoutimport time;test_journal_recovery.pygives 10 failed / 18 passed, allNameError. Needs the import before merge.i18n merge order
The locale PRs overlap heavily, so they cannot be merged in arbitrary order:
CONFLICTING.Remaining queue (not pre-validated in this batch)
94 open PRs are not in the table above. The main groups:
CONFLICTING; feat(i18n): add complete Spanish (Spain) localization #728 (Spanish) is stale. feat(i18n): add Portuguese (pt) interface localization #2202 (Portuguese) and fix(i18n): complete the French catalog and follow it for partner replies #2204 (French) were reviewed earlier in their own threads.Merge-order hotspots
provider_registry.py: feat(providers): add CloudGPU as an OpenAI-compatible gateway #2138 and feat(providers): add LLMTR as an OpenAI-compatible gateway #2156 both insert afterruncrate; feat(providers): add xAI model coverage and Mistral embeddings/voice #2203 also touches the registry. Merge one provider PR, then rebase the others.languages.ts,settings_spec.py,interface_settings.pyand the locale catalogs; see the order above.Dockerfile: fix(docker): skip production frontend build in development #2002 and fix: pin Docker Node image to security release #2146 touch the same Node stages andtests/scripts/test_docker_compose.py; fix(docker): skip production frontend build in development #2002 needs clarification first.How to help
Pick a PR that is not in the table above, run its focused test command, and leave a short review with the command and result. If it fails, comment with the exact failure — that is more useful than a generic “LGTM”. The maintainer merges in batches, so a few verified PRs per batch go a long way.
I did not touch the maintainer’s running instance or any PR branch.
All reactions