Maven to gradle migration #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlodarcp
commented
Aug 26, 2021
| @@ -41,9 +41,6 @@ class K8sServiceLocatorFT extends Specification { | |||
|
|
|||
| static WireMockRule wireMockRule | |||
|
|
|||
| @Autowired | |||
wlodarcp
commented
Aug 26, 2021
| JavaTimeModule javaTimeModule = new JavaTimeModule(); | ||
|
|
||
| //According to issue https://bitbucket.org/atlassian/swagger-request-validator/issues/331/timestamp-iso8601-format-issue | ||
| Json.mapper().registerModule(javaTimeModule); |
There was a problem hiding this comment.
Issue fixed in swagger-request-validator new version
Pull Request Test Coverage Report for Build #645
💛 - Coveralls |
…in latest swagger-request-validator
wlodarcp
force-pushed
the
maven_to_gradle_migration
branch
from
a961bd8
to
921f61d
Compare
Felipe444
approved these changes
Sep 2, 2021
| @@ -57,6 +54,7 @@ class K8sServiceLocatorFT extends Specification { | |||
| wireMockRule.stop() | |||
| } | |||
|
|
|||
| @DirtiesContext(methodMode = DirtiesContext.MethodMode.BEFORE_METHOD) | |||
There was a problem hiding this comment.
After migration system properties required for this test were setting after spring context loaded, it was one possible workaraund, replaced with setting those properties in static initialization block
| ) | ||
| .andExpect(status().isOk()) | ||
| .andExpect(content().contentType("application/json;charset=UTF-8")) | ||
| .andExpect(content().contentType('application/json')) |
…atic initializer block to initialize system properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full build test:
https://github.com/HLTech/judge-d/actions/runs/1171705785