修复自动安装在 1.20.4 的严重问题

[burningtnt]

Close #2975 Close #3021

[burningtnt]

做的差不多了，需要社区帮助测试

[burningtnt]

Forge 做了更改，需要处理兼容性，将更改代码逻辑

[3gf8jv4dv]

Tested using a build based on burningtnt@560a9e9.

When Forge 49.0.49 and 49.0.50 are installed respectively and tested with OptiFine HD_U_I8_pre4, both can run normally. When building using the main branch (without this PR), the former cannot start the game, while the latter works fine.

In other launcher-installed instances, the Modloaders / OptiFine interface will prompt as expected: * Installed by external process, which cannot be configured. I tested Forge and Fabric installed by PCL2 and both prompted as expected.

[burningtnt]

Good. Thanks for your detailed testing.

[burningtnt]

By the way, may you try installing forge + optifine with the main branch, and launch the game with this PR. I've made some codes to automatically fix the optifine installed by legacy version.

[3gf8jv4dv]

By the way, may you try installing forge + optifine with the main branch, and launch the game with this PR. I've made some codes to automatically fix the optifine installed by legacy version.

If I understand correctly: I tried installing Forge 49.0.31/49.0.49 and OptiFine HD_U_I8_pre4 on a build from the main branch, then closed and opened this PR build to launch the game directly.

But the game did not launch successfully. I checked the library file and found that the mods.toml in the OptiFine related files was not deleted. Removed and reinstalled OptiFine in the Modloaders / OptiFine interface using a PR build and the game ran as expected.

[zkitefly]

By the way, may you try installing forge + optifine with the main branch, and launch the game with this PR. I've made some codes to automatically fix the optifine installed by legacy version.

If I understand correctly: I tried installing Forge 49.0.31/49.0.49 and OptiFine HD_U_I8_pre4 on a build from the main branch, then closed and opened this PR build to launch the game directly.

But the game did not launch successfully. I checked the library file and found that the mods.toml in the OptiFine related files was not deleted. Removed and reinstalled OptiFine in the Modloaders / OptiFine interface using a PR build and the game ran as expected.

可能是因为删除 mods.toml 是在安装 optifine 的时候

[burningtnt]

可能是因为删除 mods.toml 是在安装 optifine 的时候

I've made some changes to check OptiFine while checking whether the game is conplete. Maybe there's a bug here.

[burningtnt]

Has been fixed yesterday but I forgot to send a messsage. There should NOT be any bugs. (?)

[3gf8jv4dv]

Has been fixed yesterday but I forgot to send a messsage. There should NOT be any bugs. (?)

I saw the commit you pushed earlier, but I was dealing with other things at the time. I will test it later.

[3gf8jv4dv]

Tested using release-3.5.8 (release) and a build based on burningtnt@200cc50.

Builds based on this PR now correctly fix OptiFine library files under Forge & OptiFine instances for 1.20.4 installed through a launcher that does not contain this PR.

[3gf8jv4dv]

Overall it seems there is no problem.