upgrade to qoqo 1.10 + fix issue with VariableMSXX gate conversion to… #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VariableMSXX is not part of myqml gates set; so initially the idea was to extract, for every occurence of this gate in the qoqo circuit, its associated unitary matrix and use this to define a gate in myqml.
I.e. it would be handle by the case of generic
TwoQubitGateOperation
.But it seems this way does not work, and myqml instead decide to collect all instance and define them as a single gate (meaning all VariableMSXX have the same unitary matrix). This is wrong of course, since is a parametric gate.
In order to fix that I declare this gate as paramatetric defing the function to get the matrix given the theta.
Tests with quantum program seems to show that the issue is fixed.