Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/api v2 #59

Merged
merged 8 commits into from
Apr 2, 2020
Merged

Feature/api v2 #59

merged 8 commits into from
Apr 2, 2020

Conversation

quarian
Copy link
Contributor

@quarian quarian commented Apr 2, 2020

Contains the doc updates for the migration to a v2 version of the API. Compatibility on the data model level is preserved, but consumers should inspect the new API and its behaviour.

Since THL has started publishing their data, all the health care districts don't do it anymore (this makes sense). This makes updating our old style of observation based API too much work. I thought of weaving the updating THL data into our old style data, but decided agains it.

Main reason is this: we reported data based on the reporting date of the observations, and THL reports based on the testing date. We could always place the new observations on the current date if we kept our eyes open and it would offer a whole picture. That doesn't mesh well with the testing based updates (how to make sure we don't report things twice)? How would this mesh with our historical data?

By using just one of the sources we can offer a meaningful picture of the events. So consider our first API the history of the reporting of the coronavirus cases, and the new THL API the factual testing history.

This should interest @Matsuuu @VuokkoH @valstu @duukkis @Julleht @kallehjerppe @Miksus @jonniek @ultsi @mouhgang @pauliinasol @Karvaporsas @jhamberg @lovelldies @AnttiHaerkoenen @Avicted @Marantle @jussivirkkala @eevajonnapanula @jingzhe @lounjukk @Tatatofly .

@quarian quarian requested a review from EsaMakinen April 2, 2020 06:21
Copy link
Contributor

@EsaMakinen EsaMakinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good approach. There is a minimal change required for all data-using apps, but I hope and think it's doable. This will ensure that nothing is broken downstream and we will continue supplying data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants