-
Notifications
You must be signed in to change notification settings - Fork 351
Add more explanations about how to add information to the website #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As a general remark, try to respect casing for product/service names. For example, |
get_involved.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not content
-> no content
(not that the subject itself is useless...).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed.
|
howto.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before opening a pull request, one must push back to its fork...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. makes more sense now.
I incorporated the proposals and fixed the GitHub / Indico naming. |
howto.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say: Despite this is not the recommended option, if you are not confortable with Git and you only want to do simple changes, the GitHub web interface allows you to add and edit the files in your browser. In this case, you don't need to have a local clone of your personal fork
on GitHub.`
Also, in the |
Let me know once you are done w/ the review. I'll wait with my next push till then. |
In the first sentence in the page, I'd replace |
I'd also replace: ( |
I think I'm done for now! Thanks again for the work done! |
One more thing! |
And one last thing: the page title in the front-matter is incorrect: |
Incorporated your additional comments; should we merge? |
It looks much better! I have still a few (minor remark):
Should be perfect then! |
And as usual one more thing! I'd renamed the file |
Can you make the last point a bug report? |
Why did you close the PR? |
Did I close? By accident then. |
One last detail that you missed in my previous comment: the first reference to |
Done |
Thanks for all the refinements done! Merging... |
Add more explanations about how to add information to the website
Thanks. |
Job opening 2016-03-15-ucas-lhcb
Update README.md
Co-authored-by: Valentin Volkl <valentin.volkl@cern.ch>
No description provided.