Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workers #137

Merged
merged 12 commits into from
Jan 7, 2019
Merged

Workers #137

merged 12 commits into from
Jan 7, 2019

Conversation

danieldunderfelt
Copy link
Contributor

@danieldunderfelt danieldunderfelt commented Dec 31, 2018

Put the HFP fetching and caching in another thread for better UI performance. Based on PR #136, so merge that first.

@danieldunderfelt
Copy link
Contributor Author

danieldunderfelt commented Dec 31, 2018

I was planning to use workerize-loader for this, but that library has a very nasty bug that blocks me from using it. I also tried with Webpack's worker-loader but it doesn't provide the same plug-and-play workflow as Workerize.

I will look into making a PR to workerize-loader to get it to work, as it's a great tool without the bug.

@danieldunderfelt danieldunderfelt changed the title WIP Workers Workers Jan 2, 2019
@danieldunderfelt
Copy link
Contributor Author

I got workerize-loader working and made a PR to that project too. While we wait for the upstream change, I included a patch in this PR that will automatically be applied when installing dependencies.
There's still a lot of things that can be accomplished with workers. At the moment I simply moved the hfp query to a worker thread, but more exciting things can also be done!

@danieldunderfelt danieldunderfelt merged commit 60aec55 into master Jan 7, 2019
@danieldunderfelt danieldunderfelt deleted the workers branch February 13, 2019 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant