Adds focus back to highlighted contributor #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
added
bug
rviscomi
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason I removed the
tabindex='-1'from the contributors in #645 which removes the focus ring when using links like https://almanac.httparchive.org/en/2019/contributors#bazzadpCan't remember why I removed this, but suspected it was a misguided attempt to stop allowing focus on non-interactive elements - but this is a special case that should be allowed and the
-1value means it can only be set by JavaScript (indeed that's exactly what it's there for!). Highlighting the currently selected author is better for accessibility to this change I did was wrong.This adds this back in and also changes the focus outline to yellow border more in keeping with our style as it's clearly differentiated from non-highlighted contributors:
