Translation of 2020-methodology to Japanese #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bazzadp @MSakamaki |
No worries - that's what the linter is for! Still looks broken btw even after you last commit. |
tunetheweb
requested changes
Nov 13, 2020
tunetheweb
reviewed
Nov 13, 2020
tunetheweb
reviewed
Nov 13, 2020
tunetheweb
approved these changes
Nov 14, 2020
There was a problem hiding this comment.
Just one tiny indentation fix and then all good from myside. I'll go ahead and commit that.
@MSakamaki let us know if you'll get a chance to review otherwise will merge this before the next release.
tunetheweb
reviewed
Nov 14, 2020
|
@ksakae1216 @bazzadp |
MSakamaki
reviewed
Nov 15, 2020
…b.com/ksakae1216/almanac.httparchive.org into 2020-methodology-japanese-translation
|
Great work - thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I translate, Please review.
part of #1460