Caching 2020 chapter.

[raghuramakrishnan71]

Closes #917

[tunetheweb]

Is this still a work in progress @raghuramakrishnan71 ? Looks like it only has the first few sections. Can oyu change this PR to Draft until it's ready for review?

[raghuramakrishnan71]

@rviscomi @bazzadp @roryhewitt - sending an update.

• markdown for 100% content done.
• closed open review comments from reviewers.

@csswizardry @jzyang @jaisanth @Soham-S-Sarkar have completed draft markdown, and done the final edits for closing the review comments. All the images are also added to the repository.

Released for editing.

[rviscomi]

Fig 20.20 and 20.21 are appearing truncated

@raghuramakrishnan71 this sounds like the charts may have been created with wider dimensions than the default (600x371). If the charts are non-standard then the figure syntax should explicitly set the height/width arguments. See https://github.com/HTTPArchive/almanac.httparchive.org/wiki/Figures-Guide#charts-images-and-callout-figures-examples for more info.

[tunetheweb]

@bazzadp Fig 20.20 and 20.21 are appearing truncated (in the right) here: https://20201207t175252-dot-webalmanac.uk.r.appspot.com/en/2020/caching. I rechecked, the saved images are complete in the static folder also.

• 14_resource_age_party_and_type_wise_groups_1st_party.png
• 15_resource_age_party_and_type_wise_groups_3rd_party.png

@raghuramakrishnan71

Fig 20.20 and 20.21 are appearing truncated

@raghuramakrishnan71 this sounds like the charts may have been created with wider dimensions than the default (600x371). If the charts are non-standard then the figure syntax should explicitly set the height/width arguments. See https://github.com/HTTPArchive/almanac.httparchive.org/wiki/Figures-Guide#charts-images-and-callout-figures-examples for more info.

I've changed them to 600 by 371 again in the sheets. No reason for them not to be that width. I've also changed the Title of the chart to be sentence case (1st letter capitalised but test lower case).
Ok.

You'll need to retake the fallback images. Note I moved the images to standard name format so this was resource-age-party-and-type-wise-groups-1st-party.png and resource-age-party-and-type-wise-groups-3rd-party.png
Ok, Fallback images retaken for both and added.

[tunetheweb]

@raghuramakrishnan71 I think you might have missed some more of my feedback:

And pro-tip, you can batch accept all these in the Files tab, and then submit in one go – which is a lot quicker than committing them one by one.

[raghuramakrishnan71]

@bazzadp

• Have closed all comments and rechecked (except two, waiting on @roryhewitt for that). let me know if any item still appears pending.
• Thanks for the batch commit tip
• Looks like i used the review option unknowingly. Apologies.
  

[tunetheweb]

Mergeing this. We can make further edits in Copy editing.