Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured quote and 3 stats added #1628

Closed
wants to merge 1 commit into from
Closed

Featured quote and 3 stats added #1628

wants to merge 1 commit into from

Conversation

aleyda
Copy link
Contributor

@aleyda aleyda commented Dec 4, 2020

No description provided.

@aleyda aleyda mentioned this pull request Dec 4, 2020
6 tasks
@rviscomi
Copy link
Member

rviscomi commented Dec 4, 2020

Thanks @aleyda. Let's combine this with the open PR to edit the chapter: #1625.

I also wanted to give you some context how the stats will appear:

image

For example, on the home page, one of the Markup chapter's featured stats is 85.73% Percentage of pages that use the "living" HTML doctype. The number and the label are treated separately in the metadata as featured_stat_1 and featured_stat_label_1.

Could you take another turn at formatting the stats so that the number is separated from the label? That may also mean choosing between showing the mobile or desktop number. When you're done, please apply these changes to the PR as suggested edits:

image

@rviscomi rviscomi closed this Dec 4, 2020
@aleyda
Copy link
Contributor Author

aleyda commented Dec 4, 2020

Thanks for the explanation @rviscomi ! I did the changes as requested here. I hope they're better now :) Thanks

@rviscomi rviscomi deleted the aleyda-patch-1 branch December 20, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants