-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter consistency edits #275
Conversation
Fix typo Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
LGTM. @bazzadp can you also run |
…chive.org into consistency_edits
Done. Merge away if you're happy! BTW any way to ignore .DS_Store files when running |
I'm also on Mac but haven't had an issue with It should be ignored by .gitignore: https://github.com/HTTPArchive/almanac.httparchive.org/blob/master/.gitignore#L4 cc @mikegeyser |
Yeah it is ignored by git but not the generate scripts. Probably should just avoid going into those directories in finder and that'll solve that! 😀 |
Ah ok. Yeah in that case we could add some logic to the script to only handle md files and ignore the rest. |
Minor edits for consistency.
@patrickhulce I've also thrown together a Conclusion for your Third Party chapter as part of this. Feel free to edit that some more if you disagree with it.