Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter consistency edits #275

Merged
merged 6 commits into from
Oct 31, 2019
Merged

Conversation

tunetheweb
Copy link
Member

Minor edits for consistency.

@patrickhulce I've also thrown together a Conclusion for your Third Party chapter as part of this. Feel free to edit that some more if you disagree with it.

Fix typo

Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
@rviscomi rviscomi added the writing Related to wording and content label Oct 31, 2019
@rviscomi rviscomi added this to the SHIP IT! milestone Oct 31, 2019
@rviscomi
Copy link
Member

LGTM. @bazzadp can you also run npm run generate to generate the corresponding markup?

@tunetheweb
Copy link
Member Author

LGTM. @bazzadp can you also run npm run generate to generate the corresponding markup?

Done. Merge away if you're happy!

BTW any way to ignore .DS_Store files when running npm run generate? Just deleted them to avoid errors but would be nice to not have to do that each time for us Mac Users! Can look at making some edits to the scripts in tools directory if you want me to?

@rviscomi
Copy link
Member

I'm also on Mac but haven't had an issue with .DS_Store.

It should be ignored by .gitignore:

https://github.com/HTTPArchive/almanac.httparchive.org/blob/master/.gitignore#L4

cc @mikegeyser

@rviscomi rviscomi merged commit d81be45 into HTTPArchive:master Oct 31, 2019
@tunetheweb
Copy link
Member Author

Yeah it is ignored by git but not the generate scripts. Probably should just avoid going into those directories in finder and that'll solve that! 😀

@tunetheweb tunetheweb deleted the consistency_edits branch October 31, 2019 15:31
@rviscomi
Copy link
Member

Ah ok. Yeah in that case we could add some logic to the script to only handle md files and ignore the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants