Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR - Translation of the methodology template #578

Merged
merged 9 commits into from
Dec 4, 2019

Conversation

borisschapira
Copy link
Contributor

@borisschapira borisschapira commented Dec 1, 2019

A dedicated PR for this template which is quite rich in text and needs reviews.
I've added the branch to Gitlocalize but the solution doesn't succeed into cutting the HTML code in pieces, so I don't know if this will be much of an help. Feel free to comment/suggest here and I'll take it into account.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @borisschapira.

I'll let one of the others comment on the language itself, but my main feedback would be to try to keep it more consistent with the English version in terms of line breakings. It may seem picky, but it'll make it a lot easier for a non-French speaker to keep the files in sycn (e.g. if we need to change line 123 to add an attribute for some design reason). I've pointed out the first few examples, but didn't do them all as figured easier for you to do outside of GitHub GUI.

As I said in one of your comments, I actually prefer your line breaks in some places! So happy to fix French version for some, and English version for others in same PR - as long as they will be consistent when merged.

Similarly at the bottom I've changed some of the quotes to be the same (' instead of ") again just for consistency rather than any particular preference between the two.

src/templates/fr/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/fr/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/fr/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/fr/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/fr/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/fr/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/fr/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/fr/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/fr/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/fr/2019/methodology.html Outdated Show resolved Hide resolved
@borisschapira
Copy link
Contributor Author

@bazzadp I'm sorry to have been a time-waster, I didn't notice some code changes outside the wording, probably an unintentional auto-format manipulation. I have just taken over the EN and FR side-by-side versions to make sure that only the translation-related wording changes are reflected. Again, my apologies, and thank you for pointing that out to me.

@tunetheweb
Copy link
Member

Ah no need to apologise @borisschapira ! That's why we do reviews, and it shouldn't really matter anyway so did even wonder if I should raise it, but I think it'll just be easier to manage going forward if they are the same where possible. Again thanks for your efforts here.

There are still some differences though: English is 689 lines long, while French is 797 lines long. Some of this is going to be due to the nature of translations so I do wonder if we should change the English one to collapse the paragraphs to one line as part of this PR to bring them more into line?

WDYT?

@borisschapira
Copy link
Contributor Author

Yes, English and French are different and quite often, we need more words!
To make it easier, we could change the English version so that every paragraph content would be on a single line, and I can do that for the French translation too. That way, we would have a one-one line matching. I don't know how important this is to you.

@tunetheweb
Copy link
Member

I say do that. It's not a massive deal but, as I say, I think it would help if we have any technical template changes that need to be done across languages. Otherwise we might need to get native speakers involved each time to validate any changes!

@borisschapira
Copy link
Contributor Author

@bazzadp To be sure I understand, you're talking about something like that?

@tunetheweb
Copy link
Member

Yup! That’s how the chapters are written as well so good to bring these non-chapters in-line with them anyway.

And thanks for taking this on. Sorry you got lumped with this as the first translation to look at these but think others will benefit.

@borisschapira
Copy link
Contributor Author

Branch has been rebase with master.

src/templates/fr/2019/methodology.html Outdated Show resolved Hide resolved
@tunetheweb
Copy link
Member

OK looks good now. @AymenLoukil and/or @SilentJMA can one of you review the language when you get a chance and then I think we're good to merge this.

Thanks for working on this @borisschapira !

</p>

<p>
HTTP Archive puise les URLs à tester dans le <a href="#chrome-ux-report">Chrome UX Report</a>. Chrome UX Report est un jeu de données public appartenant à Google qui regroupe des informations sur l’expérience des utilisateurs et utilisatrices de Chrome lors de leurs visites sur des millions de sites Web. Il nous fournit une liste de sites Web qui sont à jour et qui reflètent l’utilisation du Web dans le monde réel. Le jeu de données du Chrome UX Report comprend une dimension relative au type de matériel utilisé, que nous exploitons pour savoir si les sites sont consultés sur ordinateurs de bureau ou périphériques mobiles.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HTTP Archive puise les URLs à tester dans le <a href="#chrome-ux-report">Chrome UX Report</a>. Chrome UX Report est un jeu de données public appartenant à Google qui regroupe des informations sur l’expérience des utilisateurs et utilisatrices de Chrome lors de leurs visites sur des millions de sites Web. Il nous fournit une liste de sites Web qui sont à jour et qui reflètent l’utilisation du Web dans le monde réel. Le jeu de données du Chrome UX Report comprend une dimension relative au type de matériel utilisé, que nous exploitons pour savoir si les sites sont consultés sur ordinateurs de bureau ou périphériques mobiles.
HTTP Archive puise les URLs à tester dans le <a href="#chrome-ux-report">Chrome UX Report</a>. Chrome UX Report est un ensemble de données public appartenant à Google qui regroupe des informations sur l’expérience des utilisateurs et utilisatrices de Chrome lors de leurs visites sur des millions de sites Web. Il nous fournit une liste de sites Web qui sont à jour et qui reflètent l’utilisation du Web dans le monde réel. L'ensemble de données du Chrome UX Report comprend une dimension relative au type de matériel utilisé, que nous exploitons pour savoir si les sites sont consultés sur ordinateurs de bureau ou périphériques mobiles.

@borisschapira
Copy link
Contributor Author

@SilentJMA "Jeu de données" is the right translation for "dataset", I think (French is spoken everywhere in the world – and often differently – so maybe it's different for you). Wikipedia tends to agree, and it seems that this is also valid in Quebec French. I suggest we keep it.

@SilentJMA
Copy link
Contributor

@SilentJMA "Jeu de données" is the right translation for "dataset", I think (French is spoken everywhere in the world – and often differently – so maybe it's different for you). Wikipedia tends to agree, and it seems that this is also valid in Quebec French. I suggest we keep it.

Un jeu de données (en anglais dataset ou data set) est un ensemble de valeurs (ou données) why i said that because i used the term of un ensemble de données before

@borisschapira
Copy link
Contributor Author

Of course. Same difference between dataset and "a data set". "dataset" is more technical, in a lexical jargon-type lexical frame.

@HTTPArchive HTTPArchive deleted a comment from borisschapira Dec 3, 2019
@HTTPArchive HTTPArchive deleted a comment from borisschapira Dec 3, 2019
@nico3333fr
Copy link
Contributor

Proofread done @borisschapira ;)

@tunetheweb
Copy link
Member

Thanks @borisschapira and @nico3333fr for your work on this.

As we have my own and one translators approval. I'm going to merge this. @allemas @AymenLoukil @SilentJMA if you have any further comments please raise a new PR or issue.

@tunetheweb tunetheweb merged commit e454667 into HTTPArchive:master Dec 4, 2019
@borisschapira borisschapira deleted the methodology-template branch December 5, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants